The ability to tag pools is requested on Github and Albert said he's fine with the idea. While waiting for him to fix more critical bugs before getting to implement this, we should discuss more, especially on how it should work.
Personally I don't think we need a new table in the database just for pool tags. Yes, there will be tags that are only used on pools (e.g. body_part, collection, series,...). But as long as tags added for pools aren't included in total tag count in Tags index (do we even need a tag count for pools??), I think it's fine to use the same tag table.
So if you have an original 4koma series about someone finding a bird, you'd tag the pool 4komabirdoriginalseries, even if it includes the occasional 5koma or single extra image or the bird isn't visible in some of the images?
Sounds quite useful. +1 from me.
Should it also be possible to add pools too pools? The ability to stick a whole pool into Heart-warming or similar has (jokingly?) been requested several times already.
The new table was because, if a certain tag/pool search (like touhou) returns mixed pools and posts it might get messy/slow internally.
Random things that come to mind:
What about the layout of http://danbooru.donmai.us/pools. Perhaps below the name, in a slightly reduced font size a list "tags: ..."? In the same ordering as the single-post page (copyrights, characters, author, other tags). Depending on how it looks, we could force it be a single line by cutting it off with "..." on overflow.
For cleaning up/references, a way to search the pool-tags for often used/correct spellings/new pool-tags would be very useful.
Once the system is in place, the pool name format "copyright - poolname - (author)" probably will fall back to just "poolname"?
What exactly do we tag (large) collection pools like "Disgustingly Adorable" with? There is no copyright, author or character tags for collections.
What about the layout of http://danbooru.donmai.us/pools. Perhaps below the name, in a slightly reduced font size a list "tags: ..."? In the same ordering as the single-post page (copyrights, characters, author, other tags). Depending on how it looks, we could force it be a single line by cutting it off with "..." on overflow.
An alternative would be to do it the way /posts does - when you hover over the pool's name, a tooltip with all its tags appears.
itsonlyaname said:
Once the system is in place, the pool name format "copyright - poolname - (author)" probably will fall back to just "poolname"?
The problem with this is duplicate pool names. The system currently doesn't allow duplicates because it would break the pool:pool_name format when adding posts to pools by editing the post's tags. "Pool Name (Author)" would probably avoid duplicate names well enough.
itsonlyaname said:
What exactly do we tag (large) collection pools like "Disgustingly Adorable" with? There is no copyright, author or character tags for collections.
The only tag that comes to mind for pools like that would be "collection". I think tags would be more useful for comic pools, in general.
itsonlyaname said: The new table was because, if a certain tag/pool search (like touhou) returns mixed pools and posts it might get messy/slow internally.
So searches can't be separated between posts and pools? I mean if there's an extra field for tags in Pools -> Search, search using that field should only be for pools. If performance is better with a new table, connection should be established so that users can go to the same tag wikis and artist entries with pool tags.
tags below pool name, in a slightly reduced font size Depending on how it looks, we could force it be a single line by cutting it off with "..." on overflow.
Sounds good to me.
Once the system is in place, the pool name format "copyright - poolname - (author)" probably will fall back to just "poolname"?
If and only if artist + copyright (possibly character) tags are always present in close proximity with pool name. Like your suggestion of placing them under the pool name. If these two tags aren't immediately present (being put in a tooltip appears on hovering), then the current name format shouldn't change.
What exactly do we tag (large) collection pools like "Disgustingly Adorable" with?
Rather than adding a new set of tags attached to the pool itself, what about the ability to search pools by the union of the tags of its member posts? For each tag in any of the posts, you could track the total number of posts in that pool that have it and display that information in some form (flat count? percentage?). And include all this new information in the pool API results.
No extra maintenance required, and more useful.
Sal-N commented: I wouldn't like that. Tagging pools have a slightly different objective than describing all of its member posts. See some example tags in my previous paragraph.
RaisingK said: Rather than adding a new set of tags attached to the pool itself, what about the ability to search pools by the union of the tags of its member posts? For each tag in any of the posts, you could track the total number of posts in that pool that have it and display that information in some form (flat count? percentage?). And include all this new information in the pool API results.
Sounds like it would work, but not as handy as being able to tag the pools.
Points for: - don't need to tag all 6k pools - no need to log extra - could be less work to code? - a lot less work to maintain (see quote below).
Points against: - Cannot be used to tag pools as either collection or series, and generally less controllable. - How would normal users search the pools? It would still require a "search pools by tags in posts" field, as well as some options like preventing pools where tags only show up rarely (like 1-2 times) from showing up in searches. - Pool tags would have to update themselves often (upon page adding, removing or any post tag edits). - 6k pools doesn't seem that much work to tag, we have at least 600k well-tagged posts.
Edit;
MyrMindservant commented (github):
The same maintenance that our already present tagging system needs. Of course, pools tagging system would be less sophisticated, but it still would have all the similar problems and require continual attention. Here are some things that I can name off the top of my head: Duplicate tags, hence tag aliases; simply useless tags and discussions related to use of particular tags; tag descriptions and consequently wikis; tag history for particular pools; tag gardening and its opposite side - tag vandalism. And don't forget that if new tag system for pools gets implemented, it needs to be completely separate from the currently existing tag system because it has different purpose and would obey different rules.
Creating and maintaining such system is a lot of work and as I've already said it is not worth the effort in my opinion.
Lightforger commented (github):
Good point, i hadn't thought about pool-tag aliases, wiki's and such yet. That does seem like a lot of work for the admins/mods.
I feel that only relying on what the majority of the posts in a pool are tagged with wouldn't work for some series pools though. (and not at all for collection pools)
The "pool is a collection/series" could be split into a seperate issue, being done with radio buttons instead of tags.
As for tagging the genre of the pool... guess that's not really required? I've seen a few warning in descriptions before like "this is a sad/depressing story".
